Skip to content

Fix Add Student metabox layout - #8147

Merged
donnapep merged 5 commits into
trunkfrom
fix/students-metaboxes
Aug 10, 2026
Merged

donnapep merged 5 commits into
trunkfrom
fix/students-metaboxes

Conversation

@donnapep

@donnapep donnapep commented Aug 10, 2026 •

Copy link
Copy Markdown
Member

Resolves #7339.

The Students styles remained in settings.scss, but settings.css stopped loading on the Students page after #5440 changed lesson metabox registration from admin_menu to add_meta_boxes.

That change correctly improved Classic Editor support, but unintentionally left the Students styles in a stylesheet no longer loaded on that screen.

Proposed Changes

  • Move Students-specific styles to the stylesheet loaded on the Students page.
  • Fix metabox spacing and place the completion checkbox below the student selector.
  • Remove the search icon and its extra input padding.

Screenshots

Before After
Before Screenshot 2026-08-10 at 5 54 33 PM

Testing Instructions

  • Open Sensei LMS → Students and select a course.
  • Confirm the Add Student metabox content is aligned and the checkbox appears below the student selector.
  • With Sensei Pro active, confirm the Manual Content Drip metabox spacing is correct.

Changelog entry

  • Automatically create a changelog entry from the details below.
Changelog Entry Details

Significance

  • Patch - Backward-compatible bug fixes

Type

  • Fixed - Fixes a bug

Message

Fix the Add Student form layout on the Students page.

@donnapep donnapep added this to the 4.26.3 milestone Aug 10, 2026
@donnapep donnapep self-assigned this Aug 10, 2026
Copilot AI lite review requested due to automatic review settings August 10, 2026 20:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses layout/spacing issues in the “Add Student to Course/Lesson” metabox on the Sensei LMS → Students admin screen (issue #7339) by relocating Students-specific CSS to the Students admin stylesheet and adjusting Select2/metabox styling.

Changes:

  • Removed Students/metabox styling from assets/css/settings.scss.
  • Scoped Students-page styles under the Students admin screen body class in assets/css/admin-custom.scss and removed the search icon/padding behavior.
  • Added a changelog entry for the UI fix.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
changelog/fix-students-metaboxes Adds changelog entry for the Students metabox layout fix.
assets/css/settings.scss Removes Students-specific metabox/select2 styling from the settings stylesheet.
assets/css/admin-custom.scss Adds Students-page-scoped CSS intended to fix metabox spacing and Select2 layout.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread assets/css/admin-custom.scss
Comment thread assets/css/admin-custom.scss
@github-actions

github-actions Bot commented Aug 10, 2026 •

Copy link
Copy Markdown
Contributor

WordPress Playground Preview

The changes in this pull request can previewed and tested using a WordPress Playground instance.

Open WordPress Playground Preview

@donnapep
donnapep merged commit 8c6decd into trunk Aug 10, 2026
24 checks passed
@donnapep
donnapep deleted the fix/students-metaboxes branch August 10, 2026 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Whitespace issue in "Add Student to Course" box

2 participants

Sponsor
SponsoredKunjungi sekarang
Promo