Repository navigation
Enhance escalation notification verbosity for Slack and MS Teams - #19674
Conversation
There was a problem hiding this comment.
All reported issues were addressed across 13 files
Tip: instead of fixing issues one by one fix them all with cubic
Re-trigger cubic
There was a problem hiding this comment.
All reported issues were addressed across 6 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
…calation parameters
There was a problem hiding this comment.
All reported issues were addressed across 14 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Fix all with cubic | Re-trigger cubic
…nks in Slack notifications
…text to fit block limits
…ove readability in schemaReviewContext
…d fix parameter block handling
There was a problem hiding this comment.
All reported issues were addressed across 29 files (changes from recent commits).
Requires human review: Auto-approval blocked because this review re-detected 1 unresolved issue already reported by Cubic.
Tip: Review your code locally with the cubic CLI to iterate faster.
Fix all with cubic | Re-trigger cubic
There was a problem hiding this comment.
All reported issues were addressed across 29 files (changes from recent commits).
Requires human review: Auto-approval blocked because this review re-detected 1 unresolved issue already reported by Cubic.
Tip: Review your code locally with the cubic CLI to iterate faster.
Fix all with cubic | Re-trigger cubic
…ve type consistency
There was a problem hiding this comment.
All reported issues were addressed across 25 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Fix all with cubic | Re-trigger cubic
There was a problem hiding this comment.
All reported issues were addressed across 25 files (changes from recent commits).
Requires human review: Auto-approval blocked because this review re-detected 1 unresolved issue already reported by Cubic.
Tip: Review your code locally with the cubic CLI to iterate faster.
Fix all with cubic | Re-trigger cubic
…nested argument support
There was a problem hiding this comment.
All reported issues were addressed across 26 files (changes from recent commits).
Requires human review: Auto-approval blocked because this review re-detected 1 unresolved issue already reported by Cubic.
Tip: Review your code locally with the cubic CLI to iterate faster.
Fix all with cubic | Re-trigger cubic
…tool call tracking
…ext from getResult and related types
deanhannigan
left a comment
There was a problem hiding this comment.
LGTM! Ran through it all this morning on teams and its solid 🚀
Description
Improve escalation message on channels. At the escalation point, the approver most probably does not know about the context of the context of it. The current messages are short like this:
This PR adds more context to these messages, in order to give enough information to the approval on what they are approving on:
Addresses
Launchcontrol
Improve escalation message on channels
Summary by cubic
Escalation approvals previously sent only short messages; Slack, MS Teams, and in-app cards now show who requested the action, what operation and tool will run, and the tool parameters explicitly shared for review.
Written for commit 2a986ed. Summary will update on new commits.