Repository navigation
[BUDI-9339] Fix App Scripts for public users - #19822
Merged
Merged
Conversation
melohagan
marked this pull request as ready for review
October 7, 2026 12:31
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
App Scripts and their CSP whitelist entries were omitted for logged-out visitors, even when the workspace was licensed. Licensing ran before the workspace middleware created the public-user context.
Run licensing after workspace resolution so the existing script-rendering and CSP checks receive the resolved tenant's license for both public and authenticated users.
Validation:
packages/types/src/sdk/koa.ts.Authentication still runs before workspace resolution, and route authorization remains afterward. Public requests now load the cached tenant license; the user quota check uses
usageChange: 0.Addresses
Fixes #16172
BUDI-9339
Screenshots
The recording shows a published Public user screen and its saved Head App Script, then the same published URL while logged in, after clearing all cookies, and after restoring login cookies. The script banner remains visible in each session. The bottom verification overlay reports the measured script/style tag counts and execution flag. Recorded on the local development stack with a development Enterprise license.
issue-16172-fix.mp4
Launchcontrol
App scripts and styles now render for logged-out visitors on public screens when the workspace has the required license.