You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Components: Notice: Handle spoken message from component, not store #15708
Currently, it is the responsibility of the notices store to emit the spoken message when a notice is created. While this ensures that any notice which operates via the createNotice store action will be spoken, it misses messages which may be displayed by using the Notice component directly. If it's agreeable that a spoken message be considered as a necessary element of the displayed notice, it would therefore make sense to migrate this out of the data store and instead implemented as an effect of the component.
Implementation notes:
Remove SPEAK control yielding and control handler:
If #15594 is merged, it adds additional consideration for polite and assertive spoken messages. This should be handled instead from the Notice and Snackbar components.
Activity
youknowriad commentedon May 20, 2019
Noting that solving this would fix #9442