Repository navigation
Add HTML block with preview. - #1391
Merged
Merged
Conversation
We'll want to separate these out.
youknowriad
reviewed
Jun 23, 2017
| <div> | ||
| { focus && | ||
| <BlockControls key="controls"> | ||
| <ul className="components-toolbar"> |
Contributor
There was a problem hiding this comment.
Can't we use the regular Toolbar component for this? I guess we just need to make the icon optional and drop the fixed width?
Member
Author
There was a problem hiding this comment.
It forces icon at the moment. And we'll probably just create a segmented-control out of this in any case.
Contributor
There was a problem hiding this comment.
as part of #1256 I updated the Toolbar component to allow this. Edit: I updated the styling only. but seems easy to drop the icon requirement
Contributor
There was a problem hiding this comment.
Could be done separately of course
Contributor
|
Designed new icon for the block here: WordPress/dashicons#207 |
youknowriad
approved these changes
Jun 23, 2017
youknowriad
left a comment
Contributor
There was a problem hiding this comment.
Works great, feel free to merge when the tests are fixed
Member
|
Awesome! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1386.