Social Link: Fix stray closing tag in Tumblr icon markup - #80257
Merged
obenland merged 1 commit intoJul 14, 2026
Conversation
The server-side Tumblr icon SVG string closed its `<path>` element twice: once with the self-closing `/>` and again with an explicit `</path>`. This produced `<path … /></path>`, which throws a W3C "Stray end tag path" validation error on every rendered Social Links block (e.g. the global footer on make.wordpress.org). Remove the redundant self-closing slash so the element is closed once via `</path>`, matching the convention used by the other icons in this file. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01V4aw9XgpM7VnE6WQ7ci6ff
Mamaduka
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
The server-side Tumblr icon SVG in
block_core_social_link_services()closes its<path>element twice — once with a self-closing/>and again with an explicit</path>:This removes the redundant self-closing slash so the element is closed exactly once.
Why?
<path … /></path>produces a stray</path>end tag, which is invalid HTML and throws a W3C validation error ("Stray end tagpath") on every front-end render of a Social Links block that includes the Tumblr service — for example, the global footer on make.wordpress.org.Note the JSX icon (
icons/tumblr.js) is already valid; only the hand-written PHP SVG string used for server rendering carries the typo, so the editor looks fine while the front end emits invalid markup.Reported downstream at https://meta.trac.wordpress.org/ticket/8317.
How?
Drops the
/from the Tumblr<path>so it closes only via</path>, matching the convention used by the other 39 icons in this file.Before:
After:
Testing Instructions
<path … ></path>with no stray</path>.Screenshots or screencast
N/A — markup-only change; the rendered icon is visually identical.
🤖 Generated with Claude Code
https://claude.ai/code/session_01V4aw9XgpM7VnE6WQ7ci6ff