Skip to content

Resolve Prettier explicitly for isolated layout - #80529

Merged
shail-mehta merged 2 commits into
trunkfrom
fix/resolve-prettier-in-isolated-layout
Jul 21, 2026
Merged

Resolve Prettier explicitly for isolated layout#80529
shail-mehta merged 2 commits into
trunkfrom
fix/resolve-prettier-in-isolated-layout

Conversation

@shail-mehta

@shail-mehta shail-mehta commented Jul 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

What? ## Why?

Follow Up of #80422 (comment)

Resolves prettier explicitly from within the test file instead of relying on it being hoisted to the root node_modules.

How?

  • Resolve prettier's path from packages/prettier-config/test/index.js using require.resolve( 'prettier' ).
  • Pass the resolved path into the generated resolveConfigScript via JSON.stringify( prettierPath ) instead of using a bare require( 'prettier' ) string.

Use of AI Tools

  • None

@shail-mehta shail-mehta self-assigned this Jul 21, 2026
@shail-mehta shail-mehta added [Type] Bug An existing feature does not function as intended [Package] Base styles /packages/base-styles [Package] Theme /packages/theme labels Jul 21, 2026
@github-actions github-actions Bot removed [Package] Base styles /packages/base-styles [Package] Theme /packages/theme labels Jul 21, 2026
@shail-mehta shail-mehta mentioned this pull request Jul 21, 2026
Merged
@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown

Size Change: 0 B

Total Size: 7.74 MB

compressed-size-action

manzoorwanijk
manzoorwanijk approved these changes Jul 21, 2026
View reviewed changes

@manzoorwanijk manzoorwanijk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@shail-mehta
shail-mehta marked this pull request as ready for review July 21, 2026 15:55
@shail-mehta
shail-mehta requested a review from ntwb as a code owner July 21, 2026 15:55
@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: shail-mehta <shailu25@git.wordpress.org>
Co-authored-by: manzoorwanijk <manzoorwanijk@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown

Flaky tests detected in 2afa013.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/29845526495
📝 Reported issues:

@shail-mehta
shail-mehta merged commit 1048917 into trunk Jul 21, 2026
47 checks passed
@shail-mehta
shail-mehta deleted the fix/resolve-prettier-in-isolated-layout branch July 21, 2026 16:27
@github-actions github-actions Bot added this to the Gutenberg 23.7 milestone Jul 21, 2026
@jonathanbossenger jonathanbossenger added [Tool] Prettier config /packages/prettier-config [Type] Build Tooling Issues or PRs related to build tooling labels Jul 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@manzoorwanijk manzoorwanijk manzoorwanijk approved these changes
@ntwb ntwb Awaiting requested review from ntwb ntwb is a code owner

Assignees

@shail-mehta shail-mehta

Labels

[Tool] Prettier config /packages/prettier-config [Type] Bug An existing feature does not function as intended [Type] Build Tooling Issues or PRs related to build tooling

Projects

None yet

Milestone

Gutenberg 23.7

Development

Successfully merging this pull request may close these issues.

3 participants

@shail-mehta @manzoorwanijk @jonathanbossenger
Sponsor
SponsoredKunjungi sekarang
Promo