GitHub workflows: Fix changelog checks for forked PRs - #80538
Merged
mirka merged 3 commits intoJul 21, 2026
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ciampo
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes the optional package changelog workflow to fetch the base branch history from the base repository instead of the pull request author's fork.
Why?
When a pull request comes from a fork whose
trunkbranch is behind upstream, the current fetch may not include the pull request's base SHA. The subsequent three-dot diff cannot resolve the merge base and may incorrectly skip the changelog check. This occurred in #80472.How?
Fetches the base branch from
$GITHUB_SERVER_URL/$GITHUB_REPOSITORY.git. These variables identify the repository running the workflow, so forked and same-repository pull requests use the upstream base history consistently.Testing Instructions
The fork's
trunkwas atae9a734, while this PR's upstream base was1048917. The baseline and fix commits can be seen in the PR history.trunkfrommirka/gutenberg, fails to resolve1048917...HEAD, and incorrectly succeeds after reporting no relevant changes.trunkfromWordPress/gutenberg, resolves the diff, and reaches the expectedPlease add a CHANGELOG entry to packages/components/CHANGELOG.mdfailure.