Repository navigation
When generating WebPs, ensure full size is generated(-scaled for large images) #174
Description
Bug Description
After #152 "Full"" sized images inserted by users will still use the original jpeg image or (-scaled version for larger images) because the WebP version is not being generated. See #152 (comment).
Proposal to fix:
- Always generate a full sized WebP version when WebP output is active
- For larger images (over
big_image_size_threshold), generate a-scaled.webpfile
Steps to reproduce
- Enable webp-uploads
- Upload and insert an image, select full size in the image properties sidebar
- view the post and check the image source
Expected:
- All image references are to
.webpfiles
Actual
- some references are to a
.jpgfile.
Screenshots
Activity
mitogh commentedon Feb 16, 2022
I agree with this behavior, however, the opposite of this behavior was introduced here:
-scaledimage remains in the original uploaded format #143Closing #122
Just want to make sure we are consistent with those behaviors moving forward.
felixarntz commentedon Feb 21, 2022
@mitogh #122 was opened based on the current implementation where all sub-sizes are only created in one version (e.g. WebP), while the original image is remaining in the original format (e.g. JPEG).
But now, given we're working towards keeping JPEG available for all sizes and using WebP in addition, this may still be a relevant issue, it doesn't conflict with #122.
@adamsilverstein I wonder though whether we should rephrase the purpose of this issue. It wouldn't make sense to me to create a WebP version of the
-scaledimage if we don't also create a WebP version for the full image if it is small enough. We should either make the decision to only create WebP versions of the sub-sizes or we should make the decision to create WebP versions of thefullsize as well, no matter whether thatfullsize is a downscaled version (i.e. if the original is too large, as mentioned here) or small enough to not need a downscaled version (i.e. not a "big" image).adamsilverstein commentedon Feb 25, 2022
We need the full sized web- to generate correct markup when the user selects a large image, see #152 (comment)
[-]When generating only WebP sub sizes, ensure WebP `-scaled` is generated and used[/-][+]When generating WebPs, ensure full size is generated(`-scaled` for large images)[/+]adamsilverstein commentedon Feb 25, 2022
I updated this ticket's title and description to more accurately describe the issue: we need to generate the "Full" sized image as a WebP in all cases (small or large image) when we are generating WebPs. For larger images this is the
-scaledimage, otherwise its just the original image we need a WebP version of.felixarntz commentedon Feb 25, 2022
Marking this as
Needs Dev- a PR for this can be started anytime, since the dependency of #142 is now completely implemented.mitogh commentedon Feb 26, 2022
Taking over this one as I think I have a good idea of how we can implement it on top of what we already have in place. :)
Replace `full` size image in the content.