You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a proposal to define ownership for each module in the Performance Lab plugin. This should help with the following:
Have clearly defined points of contact per module, someone to reach out to in case questions come up.
Have dedicated code owners per module, since the focus area leads cannot be expected to know every module inside out, especially with a growing number of modules.
Have people to monitor a to incoming issues related to the module.
Have people to take responsibility for eventually moving the module towards a WordPress core merge.
Every module should at least have one owner, but having 2-3 is encouraged if possible. Of course the above points are not going to be entirely dependent on the module owners, there will always be support from the wider performance team and community. Yet, it is crucial to have someone to keep things moving over time.
Let's discuss. If there is consensus on this idea, a good first step as part of this issue would be to define the owners for the existing modules and add them as CODEOWNERS for the respective module directories.
Pinging a few of you that have previously worked quite a bit on the existing modules here, to provide feedback on the proposal. What do you think about the above?
I like this approach as would allow iterating faster by having more owners as new modules are added as well, as you described is not easier to keep track of which changes are happening under a specific focus area. @felixarntz
Yes, this is a good idea. I think we definitely need at least 2 owners per module to make sure that we don't have a bottleneck if a module owner disappears or is offline for some period of time.
Thanks all for the replies so far! I've opened #317 with a take on the CODEOWNERS file to define the module owners. Please review.
I'd also like to ask for additional support for the following modules:
Site Health: Audit Autoloaded Options
Site Health: Audit Enqueued Assets
Based on the work so far, these are currently owned by only @manuelRod. Is anyone here interested and willing to be an additional code owner for one or both of them? Per @eugene-manuilov's comment above, it would be best to have more than one owner for each module.
Activity
felixarntz commentedon Apr 19, 2022
Pinging a few of you that have previously worked quite a bit on the existing modules here, to provide feedback on the proposal. What do you think about the above?
@adamsilverstein @mitogh @eugene-manuilov @tillkruss @spacedmonkey @manuelRod
tillkruss commentedon Apr 19, 2022
I agree and will gladly own all object cache modules.
mitogh commentedon Apr 20, 2022
I like this approach as would allow iterating faster by having more owners as new modules are added as well, as you described is not easier to keep track of which changes are happening under a specific focus area. @felixarntz
eugene-manuilov commentedon Apr 21, 2022
Yes, this is a good idea. I think we definitely need at least 2 owners per module to make sure that we don't have a bottleneck if a module owner disappears or is offline for some period of time.
manuelRod commentedon Apr 25, 2022
I agree too.
spacedmonkey commentedon Apr 25, 2022
Me too.
felixarntz commentedon Apr 25, 2022
Thanks all for the replies so far! I've opened #317 with a take on the
CODEOWNERSfile to define the module owners. Please review.I'd also like to ask for additional support for the following modules:
Based on the work so far, these are currently owned by only @manuelRod. Is anyone here interested and willing to be an additional code owner for one or both of them? Per @eugene-manuilov's comment above, it would be best to have more than one owner for each module.