Skip to content

Update paired browsing script dependencies array - #7596

Merged
westonruter merged 2 commits into
developfrom
add/wp-inert-polyfill-in-amp-devmode
Aug 3, 2023
Merged

Update paired browsing script dependencies array#7596
westonruter merged 2 commits into
developfrom
add/wp-inert-polyfill-in-amp-devmode

Conversation

@thelovekesh

Copy link
Copy Markdown
Collaborator

Summary

Fixes #7595

Checklist

PairedBrowsing depends on the wp-dom-ready script which requires:

  • wp-polyfill
    • wp-polyfill-inert
    • regenerator-runtime

This PR updates the paired browsing script dependencies array.

  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@thelovekesh
thelovekesh requested a review from westonruter August 2, 2023 20:23
@github-actions

github-actions Bot commented Aug 2, 2023

Copy link
Copy Markdown
Contributor

Plugin builds for 533d73d are ready 🛎️!

@thelovekesh
thelovekesh force-pushed the add/wp-inert-polyfill-in-amp-devmode branch from f3c49b6 to 533d73d Compare August 2, 2023 20:34

@westonruter westonruter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @milindmore22 Would you test?

@milindmore22

Copy link
Copy Markdown
Collaborator

Tested build, issues seems fixed.

Tested on Standard, Transitional, Reader Mode with Reader Mode Theme, and Legacy Theme

@thelovekesh
thelovekesh marked this pull request as draft August 3, 2023 14:10
@thelovekesh
thelovekesh marked this pull request as ready for review August 3, 2023 14:10
@westonruter westonruter added this to the v2.4.3 milestone Aug 3, 2023
@westonruter
westonruter merged commit d421f58 into develop Aug 3, 2023
@westonruter
westonruter deleted the add/wp-inert-polyfill-in-amp-devmode branch August 3, 2023 16:01
@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changelogged Whether the issue/PR has been added to release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

wp-polyfill-inert missing data-ampdevmode attribute

3 participants

Sponsor
SponsoredKunjungi sekarang
Promo