Skip to content

Update Support Links - #7912

Merged
westonruter merged 5 commits into
developfrom
update/support-links
Nov 12, 2024
Merged

Update Support Links#7912
westonruter merged 5 commits into
developfrom
update/support-links

Conversation

@westonruter

Copy link
Copy Markdown
Member

The endpoint where we were sending support data has been turned down so we need to eliminate the Support screen in favor of directing users directly to the support forum.

@westonruter westonruter added this to the v2.5.5 milestone Nov 4, 2024
@westonruter
westonruter marked this pull request as ready for review November 4, 2024 22:44
@westonruter westonruter changed the title Update Support Link Update Support Links Nov 4, 2024
@codecov

codecov Bot commented Nov 4, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.01%. Comparing base (7b016fa) to head (2472fcd).
Report is 36 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #7912      +/-   ##
=============================================
- Coverage      77.20%   77.01%   -0.19%     
+ Complexity      6771     6566     -205     
=============================================
  Files            276      272       -4     
  Lines          22970    22383     -587     
=============================================
- Hits           17733    17238     -495     
+ Misses          5237     5145      -92     
Flag Coverage Δ
javascript 65.29% <ø> (ø)
php 77.68% <100.00%> (-0.18%) ⬇️
unit 77.68% <100.00%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/Admin/SupportLink.php 95.12% <100.00%> (-1.31%) ⬇️
src/AmpWpPlugin.php 100.00% <ø> (ø)
src/Validation/URLValidationRESTController.php 92.85% <100.00%> (-0.22%) ⬇️

@westonruter

Copy link
Copy Markdown
Member Author

Build for testing: amp.zip

@milindmore22 milindmore22 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested LGTM 👍🏼

@thelovekesh

Copy link
Copy Markdown
Collaborator

Need to bust runner cache in order to fix static analysis. The error is false positive.

@westonruter

Copy link
Copy Markdown
Member Author

Hummm. Static analysis is still failing after the runner cache was busted.

@thelovekesh

Copy link
Copy Markdown
Collaborator

Seems like this bug is back with the version just released - https://github.com/phpstan/phpstan/releases/tag/2.0.1

@westonruter
westonruter merged commit e2354ba into develop Nov 12, 2024
@westonruter
westonruter deleted the update/support-links branch November 12, 2024 00:17
@pavanpatil1

Copy link
Copy Markdown

QA Passed ✅

The support screen has been removed.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants

Sponsor
SponsoredKunjungi sekarang
Promo