Pinned Watchdog version leads to problems when updating #376

Activity

1. Witoso

   added

   type:bug

   on Jun 21, 2023
2. Reinmar commented on Jun 22, 2023

   

   Reinmar

   on Jun 22, 2023

   Member

   More actions

   We also planned to expose Watchdog on the Editor class to completely avoid this additional dependency. 

   Some internal notes where we discussed this:

   • Update (13.04.2023):
     • 😂 And the above didn’t work: Expose Watchdog and Context on Editor class and update integrations.  ckeditor5#13852
     • Two options for now:
       • Add ckeditor5-watchdog to the “Framework” layer and make the base Editor expose these
         • Simpler option
         • Risk: circular dependency on types between the editor and watchdog interfaces
         • This time let’s also update the integrations to verify that it all works together
       • Merge the code from ckeditor5-watchdog to ckeditor5-core, but keep ckeditor5-watchdog as a re-export for backwards compat
         • It would make core the dep of watchdog pkg (it has no deps now)

   👍React with 👍1Reacted by Witek Socha
3. pomek

   added

   squad:platformIssue to be handled by the Platform team.Issue to be handled by the Platform team.

   on Jun 28, 2023
4. pomek commented on Jun 29, 2023

   

   pomek

   on Jun 29, 2023

   Member

   More actions

   Scope

   • We agreed to define core, engine, utils, and watchdog packages as peer dependencies.
     • They all are needed when an integrator installs the <CKEditor> component and tries to build a custom app.
     • Example: tsc needs to resolve import type { GetEventInfo } from '@ckeditor/ckeditor5-utils';, so the utils package must be installed too.
     • We require at least version 37 or higher (>=37.0.0). 37 is the first number that offers typings.
   • It's a breaking change.
   • Update the Angular guide. We should mention that peer dependencies should be installed in the same version like the editor build that integrator wants to use.

   🚀React with 🚀1Reacted by Witek Socha
5. CKEditorBot

   added

   status:plannedSet automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon.Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon.

   on Jul 3, 2023
6. psmyrek

   self-assigned this

   on Jul 7, 2023
7. CKEditorBot

   added

   status:in-progressSet automatically when an issue lands in the "In progress" column. We are working on it.Set automatically when an issue lands in the "In progress" column. We are working on it.

   and removed

   status:plannedSet automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon.Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon.

   on Jul 7, 2023
8. pomek

   closed this as completedin #378on Jul 10, 2023
9. pomek

   added a commit that references this issue on Jul 10, 2023

   Merge pull request #378 from ckeditor/i/376

   ...

   This issue will close once commit 37e691a is merged into the 'master' branch.

   37e691a
10. CKEditorBot

    removed

    status:in-progressSet automatically when an issue lands in the "In progress" column. We are working on it.Set automatically when an issue lands in the "In progress" column. We are working on it.

    on Jul 10, 2023
11. pomek

    added a commit that references this issue on Jul 10, 2023

    Merge pull request #14549 from ckeditor/ckeditor5-angular/376

    ...

    11bc551
12. CKEditorBot

    added this to the iteration 65 milestone on Jul 10, 2023