Repository navigation
Revert "Don't install black on Cygwin" - #1783
Merged
Byron merged 1 commit intoDec 23, 2023
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #1766
Black 23.12.1 has been released. This has the fix for psf/black#4107.
We could impose a constraint that the previous version with the bug not be selected. But that version is fine on most platforms. The constraint could be made for just Cygwin, but that would make the requirement more complicated rather than less. In addition, it's probably possible, with a compiler and Python headers, to build that version for Cygwin, and if someone has done so, we shouldn't force them onto a newer version. Given that other test dependencies aren't pinned, I suggest not pinning
blackeither at this time, but instead simply reverting #1766 as planned.