Bug Description
Values in the Top performing keywords table overlap and need trimming further.
Also Top Earning pages.
Steps to reproduce
Screenshots
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
- In the generated PDF report, long primary values in the "Top search queries" (top performing keywords) table and the "Top earning pages" table should be truncated to a single line with an ellipsis so they fit within their cell and never overlap or crowd the adjacent metric columns.
- The truncation should match the treatment already used by the other PDF metric tables (single line, ellipsis, kept clear of the metric column).
Implementation Brief
Test Coverage
QA Brief
- Connect Search Console and AdSense so both hold report data, then generate a PDF report with every section ticked.
- Read the Top performing keywords and Top earning pages tiles in Key metrics. Confirm a label too long for its tile ends in
…, with clear space before the number beside it.
- Read the longest row of the Top search queries for your site and Top earning pages tables. Confirm each holds one line, ends in
…, and leaves a gap before the Clicks and Earnings columns.
- Read a short keyword and a short page title in those same four places. Confirm each keeps every character and shows no
….
Changelog entry
- Fix issues with long titles in "Top performing keyboards" section in PDF reports.
Bug Description
Values in the Top performing keywords table overlap and need trimming further.
Also Top Earning pages.
Steps to reproduce
Screenshots
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation Brief
Truncate the query cell in
DashboardPopularKeywordsWidgetPDF.tsxPDFLinkisn't width-bounded (queryCellis onlyflexDirection: 'row')flex: 1with a right gutter) and applymaxLines={ 1 }+textOverflow: 'ellipsis'to the query textTruncate the title cell in
indexPDF.tsx(Top earning pages)titleGroup(flex: 1)maxLines={ 1 }+textOverflow: 'ellipsis'to the title text so it truncates to one line instead of wrapping to manyPrefer applying the fix once in the shared table
PDFTabletruncates nothing today, add the truncation in its cell path (a bounded cell box plusmaxLines/textOverflowfor text) and/or provide a shared truncating-cell helper the customcellrenderers usePDFMetricTileTable(itsprimaryCellcomment): react-pdf reserves less room for the ellipsis than CSS, so use a wider right gutter (it usesmarginRight: 20) to keep truncated text clear of the metric columnTest Coverage
QA Brief
…, with clear space before the number beside it.…, and leaves a gap before the Clicks and Earnings columns.….Changelog entry