Repository navigation
fix(rest): merge env vars when setting CURLOPT_NOPROXY - #16420
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the libcurl transport implementation to respect the no_proxy and NO_PROXY environment variables when setting the CURLOPT_NOPROXY option. The review feedback highlights a potential performance and thread-safety issue with querying environment variables on every request, suggesting caching the result using a static variable. To maintain testability, the reviewer recommends splitting the implementation into cached and uncached helper functions, and updating the unit tests. Additionally, the reviewer advises against using std::string_view with temporary std::string objects to prevent potential lifetime issues.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16420 +/- ##
==========================================
+ Coverage 92.25% 92.27% +0.02%
==========================================
Files 2246 2246
Lines 212528 212564 +36
==========================================
+ Hits 196060 196151 +91
+ Misses 16468 16413 -55 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
fixes #16416