Skip to content

ci(storage): skip test leaking mocks 16522 - #16523

Merged
scotthart merged 1 commit into
googleapis:mainfrom
scotthart:storage_skip_flaky_connection_impl_test
Oct 1, 2026
Merged

scotthart merged 1 commit into
googleapis:mainfrom
scotthart:storage_skip_flaky_connection_impl_test

Conversation

@scotthart

Copy link
Copy Markdown
Member

@scotthart
scotthart requested review from a team as code owners October 1, 2026 13:53
@product-auto-label product-auto-label Bot added the api: storage Issues related to the Cloud Storage API. label Oct 1, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the connection_impl_test.cc file to skip the HedgedReadRecordsMetricsOnGlobalMeterProvider test, citing an issue with leaking mock objects (#16522). There are no review comments, and I have no feedback to provide.

@scotthart
scotthart enabled auto-merge (squash) October 1, 2026 13:54
@codecov

codecov Bot commented Oct 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.35%. Comparing base (b67a379) to head (f535739).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16523      +/-   ##
==========================================
- Coverage   92.37%   92.35%   -0.02%     
==========================================
  Files        2262     2262              
  Lines      217100   217027      -73     
==========================================
- Hits       200540   200433     -107     
- Misses      16560    16594      +34     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@scotthart
scotthart merged commit 7ee08b0 into googleapis:main Oct 1, 2026
71 checks passed

This branch was previously deployed

1 inactive deployment
false — f5357392 Deployed Oct 1, 2026 by scotthart via Save PR ref #12215
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Sponsor
SponsoredKunjungi sekarang
Promo