Repository navigation
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates MutationBatcher::IsValid to reject mutations when Options::max_batches is 0, and limits the allowed mutation size to the minimum of max_size_per_batch and max_outstanding_size. It also adds corresponding unit tests to verify these validation rules. I have no feedback to provide as the changes are correct and conform to the repository style guide.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16649 +/- ##
==========================================
- Coverage 92.53% 92.53% -0.01%
==========================================
Files 2269 2269
Lines 222896 222947 +51
==========================================
+ Hits 206250 206294 +44
- Misses 16646 16653 +7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
scotthart
approved these changes
Nov 10, 2026
Reject SingleRowMutation requests whose byte size exceeds Options::max_outstanding_size (as well as Options::max_batches == 0) up front with INVALID_ARGUMENT instead of enqueuing an un-admittable pending mutation that permanently stalls pending_mutations_ and AsyncWaitForNoPendingRequests().
sushanb
force-pushed
the
fix/bigtable-mutation-batcher-max-outstanding-size
branch
from
November 10, 2026 19:27
1ddde01 to
771b51b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SingleRowMutationrequests inMutationBatcher::IsValidwhose byte size exceedsstd::min(options_.max_size_per_batch, options_.max_outstanding_size)(as well as whenoptions_.max_batches == 0) withStatusCode::kInvalidArgument.max_outstanding_sizeintopending_mutations_whereCanAppendToBatchcan never admit it, which previously stalled all subsequent mutations andAsyncWaitForNoPendingRequests()indefinitely.Testing
MutationsExceedingMaxOutstandingSizeAreRejectedandZeroMaxBatchesIsRejectedingoogle/cloud/bigtable/mutation_batcher_test.cc.bazel test //google/cloud/bigtable:mutation_batcher_test.