Repository navigation
fix(bigtable): honor RMW AppProfileIdOption - #16652
Merged
Merged
Conversation
Merge per-call options into OptionsSpan before populating ReadModifyWriteRowRequest in Table::ReadModifyWriteRowImpl and Table::AsyncReadModifyWriteRowImpl, and propagate AppProfileIdOption from current Options onto the request and OperationContext in DataConnectionImpl::ReadModifyWriteRow and AsyncReadModifyWriteRow while preserving explicit request.app_profile_id() when AppProfileIdOption is unset.
There was a problem hiding this comment.
Code Review
This pull request updates the ReadModifyWriteRow and AsyncReadModifyWriteRow implementations in both Table and DataConnectionImpl to respect the AppProfileIdOption from the current options context, overriding the request's app profile ID when the option is set and preserving it when unset. It also adds comprehensive unit tests to verify this behavior. I have no feedback to provide.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16652 +/- ##
==========================================
- Coverage 92.53% 92.52% -0.01%
==========================================
Files 2269 2269
Lines 222896 223048 +152
==========================================
+ Hits 206250 206371 +121
- Misses 16646 16677 +31 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
scotthart
approved these changes
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OptionsintoOptionsSpanbefore populatingReadModifyWriteRowRequestinTable::ReadModifyWriteRowImplandTable::AsyncReadModifyWriteRowImplso per-callAppProfileIdOptionoverrides take effect on the outgoing wire request.AppProfileIdOptionfrominternal::SaveCurrentOptions()ontorequestandOperationContextinDataConnectionImpl::ReadModifyWriteRowandAsyncReadModifyWriteRow, while preserving an explicitrequest.app_profile_id()whenAppProfileIdOptionis unset.Testing
google/cloud/bigtable/table_test.ccandgoogle/cloud/bigtable/internal/data_connection_impl_test.cccovering per-callAppProfileIdOptionoverrides and explicitrequest.app_profile_id()preservation.bazel test //google/cloud/bigtable:table_test //google/cloud/bigtable:internal_data_connection_impl_test.