Skip to content

fix(bigtable): honor RMW AppProfileIdOption - #16652

Merged
sushanb merged 1 commit into
googleapis:mainfrom
sushanb:fix/bigtable-rmw-app-profile-id
Nov 11, 2026
Merged

sushanb merged 1 commit into
googleapis:mainfrom
sushanb:fix/bigtable-rmw-app-profile-id

Conversation

@sushanb

@sushanb sushanb commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Merge per-call Options into OptionsSpan before populating ReadModifyWriteRowRequest in Table::ReadModifyWriteRowImpl and Table::AsyncReadModifyWriteRowImpl so per-call AppProfileIdOption overrides take effect on the outgoing wire request.
  • Propagate AppProfileIdOption from internal::SaveCurrentOptions() onto request and OperationContext in DataConnectionImpl::ReadModifyWriteRow and AsyncReadModifyWriteRow, while preserving an explicit request.app_profile_id() when AppProfileIdOption is unset.

Testing

  • Added unit tests in google/cloud/bigtable/table_test.cc and google/cloud/bigtable/internal/data_connection_impl_test.cc covering per-call AppProfileIdOption overrides and explicit request.app_profile_id() preservation.
  • Verified bazel test //google/cloud/bigtable:table_test //google/cloud/bigtable:internal_data_connection_impl_test.

Merge per-call options into OptionsSpan before populating ReadModifyWriteRowRequest in Table::ReadModifyWriteRowImpl and Table::AsyncReadModifyWriteRowImpl, and propagate AppProfileIdOption from current Options onto the request and OperationContext in DataConnectionImpl::ReadModifyWriteRow and AsyncReadModifyWriteRow while preserving explicit request.app_profile_id() when AppProfileIdOption is unset.
@sushanb
sushanb requested a review from scotthart November 11, 2026 18:32
@sushanb
sushanb requested a review from a team as a code owner November 11, 2026 18:32
@product-auto-label product-auto-label Bot added the api: bigtable Issues related to the Bigtable API. label Nov 11, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the ReadModifyWriteRow and AsyncReadModifyWriteRow implementations in both Table and DataConnectionImpl to respect the AppProfileIdOption from the current options context, overriding the request's app profile ID when the option is set and preserving it when unset. It also adds comprehensive unit tests to verify this behavior. I have no feedback to provide.

@codecov

codecov Bot commented Nov 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.52%. Comparing base (5dcdef5) to head (fb2c2f6).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16652      +/-   ##
==========================================
- Coverage   92.53%   92.52%   -0.01%     
==========================================
  Files        2269     2269              
  Lines      222896   223048     +152     
==========================================
+ Hits       206250   206371     +121     
- Misses      16646    16677      +31     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sushanb
sushanb merged commit d85a179 into googleapis:main Nov 11, 2026
68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the Bigtable API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Sponsor
SponsoredKunjungi sekarang
Promo