Repository navigation
Harden GitHub Actions workflows against token disclosure - #1
Merged
Merged
Conversation
- Pin every action to a commit SHA (with version comment)
- Top-level permissions: contents: read on test.yml and pint.yml;
permissions: {} on build-phar.yml (deny-all top, contents: write job)
- persist-credentials: false on every actions/checkout (incl. build-phar
which uses softprops/action-gh-release, which authenticates via the
GITHUB_TOKEN env var, not via .git/config)
- pint.yml: switch from `composer pint` (fix mode, no-op in CI) to
`vendor/bin/pint --test` so lint issues actually fail the build.
Narrow trigger to pull_request + push to main
- Add .github/dependabot.yml (monthly, grouped, labelled)
- Add .github/CODEOWNERS so future .github/ changes need review
Same pattern as knotsphp/publicip#6.
Applies Pint auto-fixes across 6 files (bootstrap, app/Commands, config/, tests/Pest.php). All fixes are style-only: imported FQNs collapsed via fully_qualified_strict_types, blank-line normalization, unary operator spacing. No logic changed. Surfaced now because the linting workflow switched from `composer pint` (fix mode, no-op in CI) to `vendor/bin/pint --test` (fail on diff).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hardens CI in response to Composer CVE-2026-45793. Same pattern as knotsphp/publicip#6.
softprops/action-gh-release(new pin)permissions: contents: readontest.ymlandpint.ymlbuild-phar.yml: top-levelpermissions: {}(deny-all), job-levelcontents: write(needed to upload the phar asset).persist-credentials: false—softprops/action-gh-releaseuploads via the REST API, not git pushpint.yml: switch fromcomposer pint(which ran pint in fix mode and discarded the result — no-op in CI) tovendor/bin/pint --testso lint issues actually fail the build.github/dependabot.yml(monthly, grouped, labelled).github/CODEOWNERS