fix: return empty when filtering menuItems by a location with no assigned items - #3043

Code Climate has analyzed commit 670b1bf and detected 0 issues on this pull request.

View more on Code Climate.

coverage: 84.275%. remained the same
when pulling 670b1bf on justlevine:fix/menu-items-location-filter
into afe6a52 on wp-graphql:develop.

@justlevine I pulled this branch and querying for a list of menuItems when no menu has been assigned to a location still returns random menu items 🤔

@justlevine ah my bad. I was executing as an authenticated user who should see all menu items because they're not considered private. 🤦🏻‍♂️

@justlevine ah my bad. I was executing as an authenticated user who should see all menu items because they're not considered private. 🤦🏻‍♂️

If my fix worked correctly then even if the user is authenticated they should only receive the items they're actually filtering for, so it should still come back []. 🤔

ok, ya, authenticated users still get the incorrect behavior then.

@justlevine let me confirm that I didn't have anything else going on. . .like WPGraphQL Smart Cache object cache active or anything 👀

@justlevine oooh. . .so this was related to WPGraphQL Smart Cache, but not really related to caching. . .

WPGraphQL Smart Cache declares WPGraphQL as a dev dependency and my local copy of WPGraphQL Smart Cache was overriding the checked out version of WPGraphQL I was testing 🤔

Interesting.

My hunch is that we don't actually need WPGraphQL defined as a dev dependency for WPGraphQL Smart Cache. That's wild though that the dev dependency was taking precedent over the actual active WPGraphQL plugin 🤔

Anyway, by de-activating WPGraphQL Smart Cache I was able to experience the intended behavior of no nodes resolving when filtering menus by location when that location has no menu assigned yet (even for admin user)