Repository navigation
Fix: Omit default parameters from pages, template parts, and patterns - #62372
Merged
jorgefilipecosta merged 1 commit intoJun 6, 2024
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +34 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in fbc286d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9402895286
|
youknowriad
approved these changes
Jun 6, 2024
youknowriad
left a comment
Contributor
There was a problem hiding this comment.
Works great. Thanks for the fix.
jorgefilipecosta
deleted the
fix/omit-default-parameters-from-pages-template-parts-and-patterns-views
branch
June 6, 2024 17:47
ellatrix
pushed a commit
that referenced
this pull request
Jun 11, 2024
…#62372) Co-authored-by: jorgefilipecosta <jorgefilipecosta@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
ellatrix
pushed a commit
that referenced
this pull request
Jun 11, 2024
…#62372) Co-authored-by: jorgefilipecosta <jorgefilipecosta@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
…WordPress#62372) Co-authored-by: jorgefilipecosta <jorgefilipecosta@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
Member
|
This was cherry-picked to the wp/6.6 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #60709
Fixes the first bug @youknowriad identified.
Testing Instructions
1- Go to pages: The url should be
wp-admin/site-editor.php?postType=page2- Click "drafts": The url becomes something like
/wp-admin/site-editor.php?postType=page&activeView=drafts.3- Go back to "all pages" Verify the url is still
wp-admin/site-editor.php?postType=page.Repeat these steps for template parts and patterns verify that when switching views and going back to all view the URL is still the same