Site Editor: Decode HTML entities in Identity fields by drewmt · Pull Request #81269 · WordPress/gutenberg

drewmt · 2026-08-06T07:20:09Z

What?

Decode HTML entities where Site Editor Identity values are displayed:

Site Title and Site Tagline field values.
Media attachment titles shown by the Site Logo and Site Icon controls.

Why?

Identity REST values can contain strings such as Jordan's Test or
Logo & Mark. Plain React text controls otherwise display those entities
literally instead of showing the readable title.

How?

The Identity text fields decode their values in their local getValue
functions. MediaEdit decodes the attachment's REST title.rendered value at
the two text display boundaries: the compact filename and expanded replacement
label.

This keeps the change local to the affected screen/components. Source records,
IDs, URLs, alt text, sorting, filtering, validation, and unrelated DataForm
fields remain unchanged.

Testing Instructions

Automated checks run locally:

Targeted JavaScript/TypeScript lint passed.
Package JSON lint, lockfile validation, formatting, pre-commit checks, and
git diff --check passed.

No new test dependency or test files are introduced; the change stays limited
to the affected display-time decodeEntities calls.

Manual verification:

Open the Site Editor and go to Design → Identity.
Save a Site Title and Site Tagline containing &, ', or angle brackets.
Reload Identity and confirm both text fields show readable characters rather
than HTML entities.
Select a Site Logo and Site Icon whose attachment title contains &.
Confirm the selected media filename shows & rather than &.
Save and reload, then confirm all four values remain readable and editable.

Testing Instructions for Keyboard

Tab through the Site Title and Site Tagline inputs and edit the values.
Use the keyboard to choose or replace the Site Logo and Site Icon.
Confirm the media replacement control has a readable accessible name and
the form remains fully operable.

Screenshots or screencast

Not included; this restores the readable text represented by existing stored
values and does not introduce a new visual state.

Use of AI Tools

OpenAI Codex was used to help trace the value flow and run validation. I
reviewed the resulting diff and take responsibility for the contribution.

github-actions · 2026-08-06T07:20:21Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: drewmt <linewebdigital@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: jordesign <jordesign@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

github-actions · 2026-08-06T07:21:00Z

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @drewmt! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

t-hamano

Thanks for the PR!

Perhaps the key is where to decode. Personally, I think it might be best to fix it directly in the field where the problem occurs, as a minimal fix. Perhaps like this.

const fields = [
	{
		id: 'title',
		type: 'text',
		label: __( 'Site Title' ),
		description: __(
			"Displays in your site's layout via the Site Title block."
		),
		getValue: ( { item } ) => decodeEntities( item.title ?? '' ),
	},
	// ...
];

Furthermore, please note that this issue occurs across all fields of the identity screen, meaning the problem with the media field also needs to be resolved.

drewmt · 2026-08-06T14:45:28Z

Thanks for the guidance! I've moved decoding into the Identity title and tagline getters, and covered attachment titles in MediaEdit for both the visible filename and replacement label. I also added regressions for all four fields; 36 relevant tests pass locally.

t-hamano

LGTM!

Before	After

@oandregal @ntsekouras, do you think we can backport this PR to 7.1?

ntsekouras

Looks good, thanks!

ntsekouras · 2026-08-07T07:35:40Z

@t-hamano sounds good to include for 7.1.

@drewmt can you rebase please to resolve the changelog conflicts?

drewmt · 2026-08-07T07:43:15Z

Thanks, Nik! I've rebased onto the latest trunk and resolved the changelog conflicts. The PR is mergeable again, and the fresh checks are running.

github-actions · 2026-08-07T08:21:20Z

There was a conflict while trying to cherry-pick the commit to the wp/7.1 branch. Please resolve the conflict manually and create a PR to the wp/7.1 branch.

PRs to wp/7.1 are similar to PRs to trunk, but you should base your PR on the wp/7.1 branch instead of trunk.

# Checkout the wp/7.1 branch instead of trunk.
git checkout wp/7.1

# Create a new branch for your PR.
git checkout -b my-branch

# Cherry-pick the commit.
git cherry-pick 8323351f39157e0e83162d78b3551a46f2b4ffef

# Check which files have conflicts.
git status

# Resolve the conflict...
# Add the resolved files to the staging area.
git status
git add .
git cherry-pick --continue

# Push the branch to the repository
git push origin my-branch

# Create a PR and set the base to the wp/7.1 branch.
# See https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/changing-the-base-branch-of-a-pull-request.

ntsekouras · 2026-08-07T08:27:27Z

@drewmt can you handle the manual backport to wp/7.1. Let me know if you can't and I can do it.

drewmt · 2026-08-07T09:28:41Z

Thanks, Nik! I've opened #81320 with the manual backport to wp/7.1. Only the two changelog conflicts needed resolving; the source changes match the merged PR.

Co-authored-by: drewmt <linewebdigital@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: jordesign <jordesign@git.wordpress.org>

This updates the pinned commit hash of the Gutenberg repository from `ea285b45692aed6c4f95353671393402f97f0aa7` to `b9743a015526ac8fd79298fd4e96cf002cee333b`. A full list of changes included in this commit can be found on GitHub: WordPress/gutenberg@ea285b4...b9743a0 - Style states: fix state deselection when selecting the already selected block (WordPress/gutenberg#81277) - Global styles: render element styles set only inside a breakpoint (WordPress/gutenberg#81265) - Style states: Fix phantom pseudo element style output (WordPress/gutenberg#81291) - Docs: remove breakpoint-only element style example from global styles guide (WordPress/gutenberg#81308) - theme.json schema: responsive states belong to blocks (WordPress/gutenberg#81253) - theme.json schema: allow responsive states on block style variations (WordPress/gutenberg#81309) - Render viewport state element styles in the editor (WordPress/gutenberg#81307) (WordPress/gutenberg#81311) - Site Editor: Decode HTML entities in Identity fields (WordPress/gutenberg#81269) (WordPress/gutenberg#81320) - Editor: Keep the canvas height stable while resizing the canvas (WordPress/gutenberg#81374) - Playlist: Normalize Waveform Player configuration handling (WordPress/gutenberg#81375) - Playlist: Improve audio conversion and track selection (WordPress/gutenberg#80926) (WordPress/gutenberg#81385) - fix: order site identity changes predictably (WordPress/gutenberg#81283) - Cover: Avoid passing null as the featured image size (WordPress/gutenberg#81444) - components/Menu: Restore Modal focus return when menu items close (WordPress/gutenberg#81446) - Notes: Fix text wrapping for long usernames in collaboration sidebar (WordPress/gutenberg#81406) - Site Editor: Use inverted ThemeProvider seed for portaled UI (WordPress/gutenberg#81296) Props wildworks. See #65529. git-svn-id: https://develop.svn.wordpress.org/branches/7.1@63209 602fd350-edb4-49c9-b593-d223f7449a82

Co-authored-by: drewmt <linewebdigital@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: jordesign <jordesign@git.wordpress.org>

This updates the pinned commit hash of the Gutenberg repository from `ea285b45692aed6c4f95353671393402f97f0aa7` to `b9743a015526ac8fd79298fd4e96cf002cee333b`. A full list of changes included in this commit can be found on GitHub: WordPress/gutenberg@ea285b4...b9743a0 - Style states: fix state deselection when selecting the already selected block (WordPress/gutenberg#81277) - Global styles: render element styles set only inside a breakpoint (WordPress/gutenberg#81265) - Style states: Fix phantom pseudo element style output (WordPress/gutenberg#81291) - Docs: remove breakpoint-only element style example from global styles guide (WordPress/gutenberg#81308) - theme.json schema: responsive states belong to blocks (WordPress/gutenberg#81253) - theme.json schema: allow responsive states on block style variations (WordPress/gutenberg#81309) - Render viewport state element styles in the editor (WordPress/gutenberg#81307) (WordPress/gutenberg#81311) - Site Editor: Decode HTML entities in Identity fields (WordPress/gutenberg#81269) (WordPress/gutenberg#81320) - Editor: Keep the canvas height stable while resizing the canvas (WordPress/gutenberg#81374) - Playlist: Normalize Waveform Player configuration handling (WordPress/gutenberg#81375) - Playlist: Improve audio conversion and track selection (WordPress/gutenberg#80926) (WordPress/gutenberg#81385) - fix: order site identity changes predictably (WordPress/gutenberg#81283) - Cover: Avoid passing null as the featured image size (WordPress/gutenberg#81444) - components/Menu: Restore Modal focus return when menu items close (WordPress/gutenberg#81446) - Notes: Fix text wrapping for long usernames in collaboration sidebar (WordPress/gutenberg#81406) - Site Editor: Use inverted ThemeProvider seed for portaled UI (WordPress/gutenberg#81296) Props wildworks. See #65529. Built from https://develop.svn.wordpress.org/branches/7.1@63209 git-svn-id: http://core.svn.wordpress.org/branches/7.1@62402 1a063a9b-81f0-0310-95a4-ce76da25c4cd

drewmt requested review from gigitux, ntsekouras and oandregal as code owners August 6, 2026 07:20

github-actions Bot added the [Package] DataViews /packages/dataviews label Aug 6, 2026

github-actions Bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Aug 6, 2026

t-hamano reviewed Aug 6, 2026

View reviewed changes

t-hamano added [Type] Bug An existing feature does not function as intended [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Aug 6, 2026

t-hamano added this to WordPress 7.1 Editor Tasks Aug 6, 2026

github-project-automation Bot moved this to 🔎 Needs Review in WordPress 7.1 Editor Tasks Aug 6, 2026

t-hamano moved this from 🔎 Needs Review to 🏗️ In Progress in WordPress 7.1 Editor Tasks Aug 6, 2026

t-hamano moved this from 🏗️ In Progress to 🔎 Needs Review in WordPress 7.1 Editor Tasks Aug 6, 2026

drewmt changed the title ~~DataForms: Decode HTML entities in text inputs~~ Site Editor: Decode HTML entities in Identity fields Aug 6, 2026

github-actions Bot added [Package] Edit Site /packages/edit-site [Package] Fields /packages/fields and removed [Package] DataViews /packages/dataviews labels Aug 6, 2026

t-hamano reviewed Aug 6, 2026

View reviewed changes

Comment thread packages/edit-site/package.json Outdated

t-hamano approved these changes Aug 7, 2026

View reviewed changes

ntsekouras approved these changes Aug 7, 2026

View reviewed changes

t-hamano added the Backport to WP 7.1 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Aug 7, 2026

drewmt added 4 commits August 7, 2026 10:40

DataForms: Decode HTML entities in text inputs

25f57e9

DataForms: Link changelog entry to pull request

1b783ad

Site Editor: Decode Identity field entities

351bc93

Site Editor: Simplify Identity entity fix

ca6214c

drewmt force-pushed the fix/dataform-decode-html-entities branch from dec1f3b to ca6214c Compare August 7, 2026 07:42

ntsekouras enabled auto-merge (squash) August 7, 2026 07:44

ntsekouras merged commit 8323351 into WordPress:trunk Aug 7, 2026
58 checks passed

github-project-automation Bot moved this from 🔎 Needs Review to ✅ Done in WordPress 7.1 Editor Tasks Aug 7, 2026

github-actions Bot added this to the Gutenberg 23.8 milestone Aug 7, 2026

drewmt mentioned this pull request Aug 7, 2026

Site Editor: Decode HTML entities in Identity fields (#81269) #81320

Merged

ntsekouras removed the Backport to WP 7.1 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Aug 7, 2026

t-hamano added the Backported to WP Core Pull request that has been successfully merged into WP Core label Aug 7, 2026

youknowriad mentioned this pull request Aug 13, 2026

Extensible Site Editor: Add the Identity route #81576

Merged

Navigation Menu

Uh oh!

Site Editor: Decode HTML entities in Identity fields - #81269

Site Editor: Decode HTML entities in Identity fields#81269
ntsekouras merged 4 commits into
WordPress:trunkfrom
drewmt:fix/dataform-decode-html-entities

drewmt commented Aug 6, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Aug 6, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Aug 6, 2026

Uh oh!

t-hamano left a comment

Uh oh!

drewmt commented Aug 6, 2026

Uh oh!

Uh oh!

t-hamano left a comment

Uh oh!

ntsekouras left a comment

Uh oh!

ntsekouras commented Aug 7, 2026

Uh oh!

drewmt commented Aug 7, 2026

Uh oh!

Uh oh!

github-actions Bot commented Aug 7, 2026

Uh oh!

ntsekouras commented Aug 7, 2026

Uh oh!

drewmt commented Aug 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

drewmt commented Aug 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What?

Why?

How?

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

Use of AI Tools

Uh oh!

github-actions Bot commented Aug 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 6, 2026

Uh oh!

t-hamano left a comment

Choose a reason for hiding this comment

Uh oh!

drewmt commented Aug 6, 2026

Uh oh!

Uh oh!

t-hamano left a comment

Choose a reason for hiding this comment

Uh oh!

ntsekouras left a comment

Choose a reason for hiding this comment

Uh oh!

ntsekouras commented Aug 7, 2026

Uh oh!

drewmt commented Aug 7, 2026

Uh oh!

Uh oh!

github-actions Bot commented Aug 7, 2026

Uh oh!

ntsekouras commented Aug 7, 2026

Uh oh!

drewmt commented Aug 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

drewmt commented Aug 6, 2026 •

edited

Loading

github-actions Bot commented Aug 6, 2026 •

edited

Loading