Editor: Handle nested array block gap values properly - #12604
Closed
tyxla wants to merge 1 commit into
Closed
Conversation
Guard against non-scalar (nested array) `blockGap` values in `wp_sanitize_block_gap_value()` before passing them to `preg_match()`, which requires a string subject. A malformed axial gap value such as `blockGap.top` = `["1rem"]` previously triggered an uncaught `TypeError`, breaking front-end rendering and REST API responses. Non-scalar values are now treated as invalid and set to `null`, and scalar values are cast to string for the regex check. Includes a direct unit test for `wp_sanitize_block_gap_value()` and a data-provider case covering rendering with a malformed axial block gap. Ports WordPress/gutenberg#80464 to core. Props tyxla. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Fixes #65667.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
pento
pushed a commit
that referenced
this pull request
Jul 20, 2026
Guard against non-scalar (nested array) `blockGap` values in `wp_sanitize_block_gap_value()` before passing them to `preg_match()`, which requires a string subject. A malformed axial gap value such as `blockGap.top` being `array( '1rem' )` previously triggered an uncaught `TypeError`, breaking front-end rendering and REST API responses. Includes a direct unit test for `wp_sanitize_block_gap_value()` and a data provider case in `Tests_Block_Supports_Layout` covering rendering with a malformed axial block gap. Developed in #12604. Ports WordPress/gutenberg#80464 to Core. Props tyxla, ramonopoly. Fixes #65667. git-svn-id: https://develop.svn.wordpress.org/trunk@62801 602fd350-edb4-49c9-b593-d223f7449a82
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an uncaught
TypeErrorinwp_sanitize_block_gap_value()when ablockGapaxis holds a nested array rather than a scalar:The function iterates array gap values and passes each directly to
preg_match(), which requires a string subject. A malformed axial gap value such asblockGap.top=["1rem"]fatals, breaking front-end rendering and REST API responses.Non-scalar values are now treated as invalid and set to
null, and scalar values are cast to string for the regex check.This has been present since 6.0, when the array
foreachbranch was introduced in f187393.Testing Instructions
Automated
Manual
/wp-json/wp/v2/pages/<PAGE_ID>.Notes
Ports WordPress/gutenberg#80464 to core.
Trac ticket: https://core.trac.wordpress.org/ticket/65667
🤖 Generated with Claude Code