Skip to content

docs(docs-infra): generate valid HTML for the update guide. - #56390

Closed
JeanMeche wants to merge 1 commit into
angular:mainfrom
JeanMeche:docs/update-guide-p
Closed

JeanMeche wants to merge 1 commit into
angular:mainfrom
JeanMeche:docs/update-guide-p

Conversation

@JeanMeche

@JeanMeche JeanMeche commented Jun 11, 2024 •

Copy link
Copy Markdown
Member

Nested block elements in a p element are not valid. The p block automatically closes if another block-level element is parsed before the closing.
This results in a DOM that is different from the parsed HTML. This is known to break hydration.

@JeanMeche JeanMeche added adev: preview action: review The PR is still awaiting reviews from at least one requested reviewer area: adev labels Jun 11, 2024
@ngbot ngbot Bot added this to the Backlog milestone Jun 11, 2024
@angular-robot angular-robot Bot added the area: docs Related to the documentation label Jun 11, 2024
@github-actions

github-actions Bot commented Jun 11, 2024 •

Copy link
Copy Markdown

Deployed adev-preview for 56c4d28 to: https://ng-dev-previews-fw--pr-angular-angular-56390-adev-prev-ukcri5em.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

Nested block elements in a `p` element are not valid.
The p block automatically closes if another block-level element is parsed before the closing.
@JeanMeche
JeanMeche force-pushed the docs/update-guide-p branch from eb19220 to 56c4d28 Compare June 11, 2024 23:51
@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jun 11, 2024
@AndrewKushnir

Copy link
Copy Markdown
Contributor

This PR was merged into the repository by commit 160171e.

The changes were merged into the following branches: main, 18.0.x

AndrewKushnir pushed a commit that referenced this pull request Jun 12, 2024
Nested block elements in a `p` element are not valid.
The p block automatically closes if another block-level element is parsed before the closing.

PR Close #56390
@JeanMeche
JeanMeche deleted the docs/update-guide-p branch June 12, 2024 14:05
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Jul 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker adev: preview area: docs Related to the documentation target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Sponsor
SponsoredKunjungi sekarang
Promo