Skip to content

Improve I18N Issues Based on 2.6.3 - #132

Merged
pwkip merged 2 commits into
pwkip:masterfrom
alexclassroom:master
Aug 14, 2026
Merged

Improve I18N Issues Based on 2.6.3#132
pwkip merged 2 commits into
pwkip:masterfrom
alexclassroom:master

Conversation

@alexclassroom

Copy link
Copy Markdown
Contributor
  1. Make some UI strings translatable.
  2. Using esc_html/esc_attr functions makes code more secure.
  3. Make this plugin have a unique text domain.

@pwkip
pwkip merged commit c1122cb into pwkip:master Aug 14, 2026
@pwkip

pwkip commented Aug 14, 2026

Copy link
Copy Markdown
Owner

Thanks — two things from this are in for 2.7.12.

The deactivate notice was using %1$s for both the opening and closing tag, so it rendered a second <a href> instead of closing the first one — a real bug, nicely spotted. And the Group name legend is now translatable.

The admin-notice strings were already reworked in 2.7.10 (#123), so that part is superseded. I left the wider _e()esc_html_e() sweep out for now, since those strings are static literals with no live escaping issue.

Note: this repo is a generated mirror of the private PRO source tree, so the merge was recorded with -s ours — your commits and authorship are in the history, but the plugin files themselves are regenerated from PRO on each release.

@pwkip

pwkip commented Aug 14, 2026

Copy link
Copy Markdown
Owner

sorry for my ai-generated comment on this pr. Really appreciate your efforts :)

pwkip added a commit that referenced this pull request Aug 14, 2026
* Fix the "deactivate the free plugin" admin notice rendering a second opening link tag instead of closing the first one. Make  the "Group name" label in the group tag generator translatable. Thanks [alexclassroom](#132)!
* Fix the `wpcf7_feedback_response` filter being registered with its priority and argument count swapped. Thanks [szepeviktor](#122)!
* Declare `Requires at least` and `Requires PHP` in the plugin header so WordPress can check them on activation. Thanks [IanDelMar](#119)!
* Raise the minimum WordPress version to 5.9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Sponsor
SponsoredKunjungi sekarang
Promo